Re: (patch) hpjyg15: hppah-nat.c & related

[Andrew Cagney <ac131313 at cygnus dot com>]

Jeffrey A Law wrote:
> 
>   In message <Pine.LNX.4.10.9912150951120.29808-100000@hpcll168.cup.hp.com>you
> write:
>   > Since I'm splitting apart changes made by HP, in various areas, over 12
>   > months, into multiple patches, there's a need for me to run indent on
>   > the patched source to ensure that the GNU coding style in gdb source is
>   > adhered to.  I will make sure that pure formatting changes (line breaks)
>   > made by HP are not introduced along with real changes.
> Well, there may be instances where you have a real change that required a
> formatting update.  ie consider if you had
> 
>   if (foo)
>     blah

> You missed another alternative, which I'd tend to favor.
> 
> 1. Run intent on the gdb source files.  Submit that as a patch.  That should be
>    acceptable without problems.
> 
> 2. Apply the patch from wdb using whatever means are possible (patch -l ?).
> 
> 3. Re-run indent on the changed files.
> 
> 4. Submit the patch resulting from diffing the output of steps #1 and #3.

From memory, one of the original problems Jim[HP] found was that
re-running indent further changed the file :-(

	Andrew