This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: (patch) hpjyg15: hppah-nat.c & related

Jeff, thanks for taking the time looking at the patches!

Since I'm splitting apart changes made by HP, in various areas, over 12
months, into multiple patches, there's a need for me to run indent on
the patched source to ensure that the GNU coding style in gdb source is
adhered to.  I will make sure that pure formatting changes (line breaks)
made by HP are not introduced along with real changes.

However as we've discovered, due to a combination of a potential indent
program problem and the fact that there're places in snapshot sources
where formatting is actually necessary, there's another kind of pure
formatting changes which can come from this combination (and my running
indent before making the patch).  There're several ways to handle this:

1) generate patch using GNU diff -w option (ignore white space), and
   apply patch using patch -l (--ignore-whitespace) option.
   :: I like this approach and I'll do it if you guys are willing to
   give this a try.

2) don't run indent before generating patch, have maintainers do
   that before checking into CVS.
   :: could work.  If necessary I can provide a ksh script to do this,
   incorporating the special-case handlings documented by Stan during
   the GDB reformat (so one do not indent a file which is not supposed
   to be indented).

3) patch submitter manually remove pure formatting change noises from
   :: least favored.

- Jimmy Guo,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]