This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: (patch) hpjyg15: hppah-nat.c & related


>Don't forget that the GDB's coding style is defined by the output of
>indent.  Looking more closely I noticed that some of the changes are to
>``fix'' the indentation. Please just grit your teath and ignore it.
>
>It's a good idea to carefully review the diffs and revert/remove any
>changes not specific to the problem at hand.
>
>Doing this makes the reviewers life so much easier.

Andrew,

I'm aware of this problem and I'm trying to resolve this.  Interestly,
yes I'm reversing what indent did, _not_ to create noises, but to remove
them.  If you run indent on, say hppah-nat.c, straight from the 19991108
snapshot, you will see that it's not in GDB's coding style (since indent
is not happy with the way the code is!)

I _ran_ indent on source files before I make a patch (ok, in some cases
I might forgot to do so which might have turned out to be a good thing)
... and that's how most diff noises are introduced.  I came to realize
this and am starting to do the reserve -- change back what indent changed
that's not relevant to the patch, to make the changes in my patches
conform to GDB's coding style.  Given how much indent changes a source
file, it could be very time consuming and 'non-productive', but I'm
doing my share to help the situation.

BTW, I'm using indent 1.9.1 on Linux, with no arguments.

- Jimmy Guo, guo@cup.hp.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]