This is the mail archive of the
mailing list for the GDB project.
Re: print_symbol_info patch for source code not current language
- To: Jim Blandy <jimb at cygnus dot com>
- Subject: Re: print_symbol_info patch for source code not current language
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Fri, 29 Oct 1999 13:08:23 -0700
- CC: Pierre Muller <muller at cerbere dot u-strasbg dot fr>, gdb-patches at sourceware dot cygnus dot com
- Organization: Cygnus Solutions
- References: <381824BF.BCE63370@cygnus.com> <firstname.lastname@example.org> <199910291101.NAA00678@cerbere.u-strasbg.fr> <email@example.com>
Jim Blandy wrote:
> > Shouldn't we use the language of source if known at least if
> > the current language mode is auto ??
> > This short patch to symtab.c solve this problem
> This looks good!
> However, saving, setting, and restoring the current language is
> somewhat messy. Note that the definition of type_print just calls
> LA_PRINT_TYPE, which calls current_language->la_print_type. Your code
> could simply determine the appropriate language, L, and then call
> L->la_print_type directly, instead of print_type.
Sounds like a good idea.
> I don't know if it is possible for symbols to have language_auto as
> their language. It is probably best to handle that case somehow, even
> if it never arises.
How about if "language_auto" symbols default
to current_language (as all symbols currently do)?