This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
m68k-stub.c patch, putpacket() should wait for ACK
- To: gdb-patches@sourceware.cygnus.com
- Subject: m68k-stub.c patch, putpacket() should wait for ACK
- From: jtc@redback.com (J.T. Conklin)
- Date: 17 Aug 1999 22:33:22 -0700
- Reply-To: jtc@redback.com
This is a re-send of a patch I sent back in March. It wasn't
rejected, but it wasn't integrated either. See the gdb-patches
archive for a more detailed rationale for this patch.
This also fixes the comment before putpacket() in the sh stub.
--jtc
1999-08-17 J.T. Conklin <jtc@redback.com>
* m68k-stub.c (putpacket): Restore code so that packets are sent
until an ACK is received.
Index: m68k-stub.c
===================================================================
RCS file: /home/jtc/CVSROOT/gdb/gdb/m68k-stub.c,v
retrieving revision 1.2
diff -c -r1.2 m68k-stub.c
*** m68k-stub.c 1999/08/18 05:09:24 1.2
--- m68k-stub.c 1999/08/18 05:23:17
***************
*** 591,598 ****
}
}
! /* send the packet in buffer. The host get's one chance to read it.
! This routine does not wait for a positive acknowledge. */
void putpacket(buffer)
char * buffer;
--- 591,597 ----
}
}
! /* send the packet in buffer. */
void putpacket(buffer)
char * buffer;
***************
*** 617,623 ****
putDebugChar(hexchars[checksum >> 4]);
putDebugChar(hexchars[checksum % 16]);
! } while (1 == 0); /* (getDebugChar() != '+'); */
}
--- 616,622 ----
putDebugChar(hexchars[checksum >> 4]);
putDebugChar(hexchars[checksum % 16]);
! } while (getDebugChar() != '+');
}
Index: sh-stub.c
===================================================================
RCS file: /home/jtc/CVSROOT/gdb/gdb/sh-stub.c,v
retrieving revision 1.2
diff -c -r1.2 sh-stub.c
*** sh-stub.c 1999/08/18 05:09:25 1.2
--- sh-stub.c 1999/08/18 05:24:06
***************
*** 444,451 ****
}
}
! /* send the packet in buffer. The host get's one chance to read it.
! This routine does not wait for a positive acknowledge. */
static void
putpacket (register char *buffer)
--- 444,450 ----
}
}
! /* send the packet in buffer. */
static void
putpacket (register char *buffer)
--
J.T. Conklin
RedBack Networks