This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: fix up Syscall a bit


>> {
>> syscall = task.getIsa().syscallByName(name);
>> }
>> -    catch (Exception e)
>> +    catch (TaskException e)
>> {
>> -	throw new RuntimeException ("Could not get the name of isa");
>> +	throw new RuntimeException ("Could not get the name of isa", e);
>> }
>> return syscall;
>> 

Phil> This exception will stop the event loop for implementing clients (and
Phil> as the exception is unchecked, very hard to check on the
Phil> severity). Would it be better to return null in these places instead
Phil> of completely aborting with a throw?

>From what I can tell this only occurs if Task.getIsa() fails.
But if that fails I think something pretty bad is going on
here... since it means the code is watching a Task, sees a system
call, and then the Task fails to return its ISA.  To me that sounds
like an internal error of some kind, but I don't actually know for
certain.  Is there a "normal" situation in which this might happen?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]