This is the mail archive of the
mailing list for the frysk project.
Re: Patch: fix up Syscall a bit
- From: Tom Tromey <tromey at redhat dot com>
- To: Phil Muldoon <pmuldoon at redhat dot com>
- Cc: Frysk Hackers <frysk at sourceware dot org>
- Date: 18 Sep 2006 10:43:14 -0600
- Subject: Re: Patch: fix up Syscall a bit
- References: <email@example.com> <450EC8E3.firstname.lastname@example.org>
- Reply-to: tromey at redhat dot com
>> syscall = task.getIsa().syscallByName(name);
>> - catch (Exception e)
>> + catch (TaskException e)
>> - throw new RuntimeException ("Could not get the name of isa");
>> + throw new RuntimeException ("Could not get the name of isa", e);
>> return syscall;
Phil> This exception will stop the event loop for implementing clients (and
Phil> as the exception is unchecked, very hard to check on the
Phil> severity). Would it be better to return null in these places instead
Phil> of completely aborting with a throw?
>From what I can tell this only occurs if Task.getIsa() fails.
But if that fails I think something pretty bad is going on
here... since it means the code is watching a Task, sees a system
call, and then the Task fails to return its ISA. To me that sounds
like an internal error of some kind, but I don't actually know for
certain. Is there a "normal" situation in which this might happen?