Re: Patch: StackFrame.toString()

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Yao" == Yao Qi <qiyaoltc@cn.ibm.com> writes:

>> I'm happy to document these accessors if someone would confirm that
>> this is the intended interpretation.

Yao> This patch is fine to me.

Thanks.  I'll write up javadoc for StackFrame sometime soon.

>> +  public String toString ()
>> +  {
>> +    StringBuffer builder = new StringBuffer("at 0x");
>> +    builder.append(Long.toHexString(getAddress()));
>> +    String mn = getMethodName();
>> +    if (mn != null && ! "".equals(mn))

Yao> Just one question for my curiosity,
Yao> Is there any difference between ""equals(mn) and mn.equals("")?

It is a fairly common java style to write it as "".equals(mn), because
this will avoid a NullPointerException if mn==null.  In this case it
doesn't matter as we're explicitly checking for null.

Tom