Re: frysk-gui lib/opcodes/Disassembler.java lib/op ...

[Mike Cvet <mcvet at redhat dot com>]

On Fri, 2006-09-15 at 08:30 +0800, Yao Qi wrote:
> On Thu, Sep 14, 2006 at 08:31:19PM -0000, mcvet@sourceware.org wrote:
> > 
> > Log message:
> > 	frysk-imports/lib/opcodes:
> > 	2006-09-14  Mike Cvet  <mcvet@redhat.com>
> > 	
> > 	* Disassembler.java (appendCurrentInstruction): Changed from
> > 	setCurrentInstruction to prevent overwriting the given
> > 	instruction with the parameters. Now properly appends
> > 	parameters to instructions.
> > 	* cni/Disassembler.cxx (disassemble): Changed the
> > 	i386 and x86_64 instruction flavours to att.
> > 	(read_from_byte_buffer): Fixed up formatting.
> > 	(print_addr): Changed from an empty function to one that
> > 	updates the Disassembler object with the instruction
> > 	address parameter.
> > 	(save_instruction): Fixed up formatting.
> Hi, Mike,
> I think I submitted a patch to do similar thing, support ppc64
> additionally, on Sep. 3rd,
> http://sources.redhat.com/ml/frysk/2006-q3/msg00371.html
> 
> Maybe, I should declare loudly in maillist to avoid duplicate work, :)
> I could start to add ppc64 support on your code.
> 

Yao - you're absolutely right. I didn't think to check previous mailing
list patches because you now have commit access. My bad.

Yes, please go ahead and do any PPC/64 work you need on that file =)

- Mike