This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New method to get real length of register


On Wed, Aug 23, 2006 at 02:39:30PM +0200, Mark Wielaard wrote:
> Hi,
> 
> It might be easier if you define an additional constructor for Register
> that takes the realLenght and stores it in an instance field. That way
> you don't have to define all these methods for each individual register,
> which makes the code less readable imho. See attached for an example.

Hmmm, It seems that you are right, Mark!

The reason why I do not add a new member in Register is that most of
the registers get the same thing from getLength() and
getRealLength(), but do not think too much about readability, :)

Thanks for your comments, and I will modify this patch per your
advice.

-- 
Yao Qi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]