This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: one frysk-core patch to add PPC64 testcases.

Yong Zheng wrote:
hi,

There's no any case for us to test register and memory modification in
PPC64 in frysk. So we write two cases for above purpose. During the
test, we found the PPC64's worksize(got from IsaPPC64.java) should be
8bytes but not 4 bytes. Here is the patch to add PPC64 tests.

2006-08-18 Yong Zheng <zhengyo@cn.ibm.com>

	* frysk/proc/TestPPC64Regs.java: New file for PPC64 test
	* frysk/proc/TestPPC64Modify.java: New file for PPC64 test
	* frysk/pkglibexecdir/funit-ppc64-regs.S: New file for PPC64
	* frysk/pkglibexecdir/funit-ppc64-modify.S: Ditto
	* frysk/Makefile.am: Add PPC64Regs/PPC64Modify tests

	* frysk/proc/IsaPPC64.java (getWordSize): Edit return value
	from 4 to 8

Rather than individual Test<ISA>Regs.java files, I'd prefer to see a single TestRegs.java file that selects the applicable test and runs that, or fails if no test is implemented.

Past experience tells us that, unless unimplemented is detected and treated as a FAIL, the tests won't get implemented - too easy to ignore.

Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]