This is the mail archive of the
frysk@sources.redhat.com
mailing list for the frysk project.
Re: one frysk-core patch to add PPC64 testcases.
- From: Yao Qi <qiyaoltc at cn dot ibm dot com>
- To: frysk at sourceware dot org
- Date: Fri, 18 Aug 2006 15:36:21 +0800
- Subject: Re: one frysk-core patch to add PPC64 testcases.
- References: <1155884638.7779.25.camel@YZ_X86_64>
On Fri, Aug 18, 2006 at 03:03:58PM +0800, Yong Zheng wrote:
> hi,
>
> There's no any case for us to test register and memory modification in
> PPC64 in frysk. So we write two cases for above purpose. During the
> test, we found the PPC64's worksize(got from IsaPPC64.java) should be
> 8bytes but not 4 bytes. Here is the patch to add PPC64 tests.
It look fine to me. Here are some my comments to the format or style
of changelog and source code.
1) The description in ChangLog is a sentence, even if it is short, so
please end it with ".".
>
> 2006-08-18 Yong Zheng <zhengyo@cn.ibm.com>
>
> * frysk/proc/TestPPC64Regs.java: New file for PPC64 test
> * frysk/proc/TestPPC64Modify.java: New file for PPC64 test
> * frysk/pkglibexecdir/funit-ppc64-regs.S: New file for PPC64
> * frysk/pkglibexecdir/funit-ppc64-modify.S: Ditto
> * frysk/Makefile.am: Add PPC64Regs/PPC64Modify tests
>
> * frysk/proc/IsaPPC64.java (getWordSize): Edit return value
> from 4 to 8
>
> Rebuild frysk on X86-64/PPC64 based on the cvs head(08-18) and tested.
2) In the licence part of the source code, "IBM Corp." may be better
than "IBM Co.", so please replace "Co." with "Corp.".
3) There is no licence in these asm files. Please add them with
(C) IBM Corp. :)
>
> Best regards
> Yong Zheng
>
--
Yao Qi