This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: add two accessors to Syscall


>>>>> "Yao" == Yao Qi <qiyaoltc@cn.ibm.com> writes:

Yao> libunwind could not work with frysk core, and its java binding could
Yao> not do backtrace.  Here is a bug about it.
Yao> http://sources.redhat.com/bugzilla/show_bug.cgi?id=2936

Thanks, I added myself.

>> Also I noticed a few other oddities here and there.  For instance,
>> SyscallEventInfo.returnCode returns a long -- but apparently does not
>> sign-extend the syscall's actual return value.

Yao> SyscallEventInfo.returnCode is only a abstract method that should be
Yao> overridden in sub-class, such as in LinuxPPC64, LinuxPPC, and LinuxIa32.
Yao> The return code is sign-extended in LinuxPPC64 at least.

I think it would be preferable if all platforms did the same thing.  A
little javadoc in SyscallEventInfo explaining the return results of
these methods would help here... it would let folks porting to a new
platform know what to do.  (javadoc everywhere in frysk would be quite
helpful...)

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]