Re: frysk-imports frysk/bindir/ftrace.java frysk/d ...

[Mark Wielaard <mark at klomp dot org>]

Hi Tim,

On Thu, 2006-07-20 at 15:58 +0000, moore@sourceware.org wrote:
> Log message:
> 	Throw a TaskException from some methods in Task. This is not a
> 	RuntimeException, so fix all the affected callers too.

Sorry for the late reply, but I was cleaning up my own code to see how
to properly handle the new TaskExceptions and ran into this patch. In a
couple of files we now just do things like:

+    catch (Task.TaskException e)
+      {
+	// XXX do real exception handling
+      }

I am all for Checked Exceptions, but this is the worst way to handle
them. This just swallows the exception completely without leaving any
trace that anything went wrong. Now we are worse off then when we had
unchecked exceptions. At least then the exception doesn't just
disappear. Please do fix these locations by either explicitly printing
the exception, or better wrapping them in RuntimeExceptions and
rethrowing them.

Thanks,

Mark