This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cvs head has lots of test failures


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Phil Muldoon wrote:
> I reverted LinuxTask.hava from 1.32. The endian patch was causing a few
> issues. Perhaps the ultimate issue is in getIsa() using an elfFile which
> uses a file handle. The theory is these handles are being queued for
> Garbage Collection along with the object when the object is destroyed,
> but the system is running out of handles before the Garbage Collection
> is happening. Hopefully I have not totally mangled that explanation
> though that people worked through on irc today. ;)
> 
The problem is that the file descriptor passed to libelf is *never*
closed, whether or not the Elf Java object is garbage collected. I've
added an explicit close() method for the Elf object so that getIsa() can
release the file descriptor right away, and of course added the code to
close the file descriptor. frysk-core TestRunner tests run now, but I'm
going to sleep in it before checking in my code.

>
>>>> On Thu, 2006-08-10 at 09:06 -0400, Elena Zannoni wrote:
>>>>  
>>>>> Mark Wielaard writes:
>>>>>  >  > We really need an autobuilder to catch such things early.
>>>>>
>>>>> We really need people to run make check before checking stuff in.
>>>>> Please folks be considerate to your fellow coders...

Mea culpa for not running the tests more carefully, though in my defense
the tests were broken at the time on x8664 :)

Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFE27P5eDhWHdXrDRURAmdVAJ9FhkhB9S2wd3dOacNIKAOX6g7AXgCffu6R
zt98Ri3j0ZKjWKeIU9r5tJA=
=KKdO
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]