This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cvs head has lots of test failures

I reverted LinuxTask.hava from 1.32. The endian patch was causing a few issues. Perhaps the ultimate issue is in getIsa() using an elfFile which uses a file handle. The theory is these handles are being queued for Garbage Collection along with the object when the object is destroyed, but the system is running out of handles before the Garbage Collection is happening. Hopefully I have not totally mangled that explanation though that people worked through on irc today. ;)

Regards

Phil

[2006-08-10 10:45] <woodzltc> pmuldoon, one question about Java's syntax: elfFile is a local variable in getIsa, when getIsa() exits, will Elf's destructor be called?

Phil Muldoon wrote:
I looked at this a little further, and I don't feel comfortable yanking patches as my knowledge in this area is slight, and does vary wildly. So you don't have to, I trawled the frysk-cvs mailing list to get a list of patches on the 8th, with their owner. ;) Please take a look, as it is right now head is busted. The list of patches I could find on the 8th belong to Tim, Mike, Sami, Stepan and Len/

Tim's patches:

2006-08-08 Tim Moore <timoore@redhat.com>
* TestI386Modify.java: (TestI386ModifyInternals.update): Change
Task.TaskException to TaskException.
Patches from IBM.
2006-08-08 Wu Zhou <woodzltc@cn.ibm.com>
* LinuxPPC64.java (returnCode): When the 29th bit of
register CCR is set, return the negation of register GPR3.
2006-08-08 Yao Qi <qiyaoltc@cn.ibm.com>
* frysk/proc/LinuxTask.java: Do not assume little endian any
more.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ChangeLog.diff?cvsroot=frysk&r1=1.384&r2=1.385

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/LinuxPPC64.java.diff?cvsroot=frysk&r1=1.1&r2=1.2

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/LinuxTask.java.diff?cvsroot=frysk&r1=1.32&r2=1.33

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/TestI386Modify.java.diff?cvsroot=frysk&r1=1.39&r2=1.40 



Modified files:
    frysk/proc     : ChangeLog Isa.java IsaEMT64.java IsaIA32.java
Log message:
    * Isa.java: GNU indentation.
    * IsaIA32.java: ditto.
    * IsaEMT64.java: ditto.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ChangeLog.diff?cvsroot=frysk&r1=1.385&r2=1.386

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/Isa.java.diff?cvsroot=frysk&r1=1.9&r2=1.10

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/IsaEMT64.java.diff?cvsroot=frysk&r1=1.1&r2=1.2

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/IsaIA32.java.diff?cvsroot=frysk&r1=1.1&r2=1.2



*********************************************************************************************************************


Mike's patches:

Modified files:
frysk/gui : ChangeLog Gui.java
Log message:
2006-08-08 Mike Cvet <mcvet@redhat.com>
* Gui.java (createDummyTagsets): Commented out for now, not
being used but still being initialized.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/ChangeLog.diff?cvsroot=frysk&r1=1.336&r2=1.337

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/Gui.java.diff?cvsroot=frysk&r1=1.53&r2=1.54


Modified files:
frysk/gui/monitor: ChangeLog frysk/gui/monitor/actions: RunExternal.java
Log message:
2006-08-08 Mike Cvet <mcvet@redhat.com>
* actions/RunExternal.java (RunExBlocker): Added.
(TaskTerminatedObserver.updateTerminated): Updated to unblock the examined task when finished.
(AttachedObserver.updateAttached): Requests a Terminating Observer on the external process.
(execute): Creates a new RunExBlocker and requests it to attach to the incoming Task.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/ChangeLog.diff?cvsroot=frysk&r1=1.326&r2=1.327

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/actions/RunExternal.java.diff?cvsroot=frysk&r1=1.4&r2=1.5


Modified files:
frysk/gui : ChangeLog frysk/gui/glade: procpop.glade
Log message:
2006-08-08 Mike Cvet <mcvet@redhat.com>
* glade/procpop.glade: Added pidColumnDialog.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/ChangeLog.diff?cvsroot=frysk&r1=1.340&r2=1.341

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/glade/procpop.glade.diff?cvsroot=frysk&r1=1.87&r2=1.88 


Modified files:
    frysk/gui/glade: procpop.glade
Log message:
    Fixed an empty dialog oops

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/glade/procpop.glade.diff?cvsroot=frysk&r1=1.88&r2=1.89


*********************************************************************************************************************



Sami's patches:

Modified files:
frysk/proc : ChangeLog ProcState.java TestTaskObserverBlocked.java frysk/gui : ChangeLog Gui.java SessionManagerGui.java frysk/gui/druid: CreateFryskSessionDruid.java frysk/gui/glade: procpop.glade frysk/gui/monitor: ChangeLog CheckedListView.java GuiProc.java ListView.java MenuBar.java SessionProcDataModel.java WindowManager.java frysk/gui/monitor/observers: ObserverManager.java TaskCloneObserver.java TaskExecObserver.java TaskForkedObserver.java TaskObserverRoot.java TaskSyscallObserver.java TaskTerminatingObserver.java frysk/gui/sessions: DebugProcess.java Added files:
frysk/gui/monitor: ProgramObserverDialog.java frysk/gui/monitor/observers: ProgramObserver.java Removed files:
frysk/gui/monitor: PickProcsDialog.java
Log message:
2006-08-08 Sami Wagiaalla <swagiaal@redhat.com>
* ProcState.java: Added handling of DetachComplete to Attaching.toMainTask.
* TestTaskObserverBlocked.java (testAddObserverAfterUnblock):
Enabled test.
2006-08-08 Sami Wagiaalla <swagiaal@redhat.com>
* sessions/DebugProcess.java: Added listining to programObserver.
* glade/procpop.glade: Added program observer menu item.
Added quit menu item.
* druid/CreateFryskSessionDruid.java (filterDatainSession): changed
getProcessies() to getProcessies().iterator.
* SessionManagerGui.java: used Gui.quitFrysk insteaf
of Gtk.mainQuit().
2006-08-08 Sami Wagiaalla <swagiaal@redhat.com>
* observers/TaskObserverRoot.java: Added unapply(Proc).
added abstrace unapply(Task).
* observers/TaskCloneObserver.java: Implemented unapply(Task).
* observers/TaskTerminatingObserver.java: Ditto.
* observers/TaskSyscallObserver.java: Ditto.
* observers/TaskForkedObserver.java: Ditto.
* observers/TaskExecObserver.java: Ditto.
* WindowManager.java: Added programObserver dialog to the list
of windows and to save/load.
* SessionProcDataModel.java: Added handling for updating
the list when new procs are added to the underlying DebugProcess.
* MenuBar.java: Added quitFryk menu item.
Removed editCustomObservers menu item.
* GuiProc.java (isOwned): Added explicit check for getExec.
* CheckedListView.java: Added getCheckedByName.
Added getCheckObjects.
* ListView (getSelectedObjects): Changed it to return a list
instead of iterator.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ChangeLog.diff?cvsroot=frysk&r1=1.386&r2=1.387

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ProcState.java.diff?cvsroot=frysk&r1=1.57&r2=1.58

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/TestTaskObserverBlocked.java.diff?cvsroot=frysk&r1=1.18&r2=1.19

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/ChangeLog.diff?cvsroot=frysk&r1=1.337&r2=1.338

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/Gui.java.diff?cvsroot=frysk&r1=1.54&r2=1.55

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/SessionManagerGui.java.diff?cvsroot=frysk&r1=1.24&r2=1.25

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/druid/CreateFryskSessionDruid.java.diff?cvsroot=frysk&r1=1.46&r2=1.47

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/glade/procpop.glade.diff?cvsroot=frysk&r1=1.86&r2=1.87

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/ProgramObserverDialog.java.diff?cvsroot=frysk&r1=NONE&r2=1.1

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/ChangeLog.diff?cvsroot=frysk&r1=1.325&r2=1.326

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/CheckedListView.java.diff?cvsroot=frysk&r1=1.11&r2=1.12

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/GuiProc.java.diff?cvsroot=frysk&r1=1.8&r2=1.9

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/ListView.java.diff?cvsroot=frysk&r1=1.25&r2=1.26

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/MenuBar.java.diff?cvsroot=frysk&r1=1.14&r2=1.15

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/SessionProcDataModel.java.diff?cvsroot=frysk&r1=1.19&r2=1.20

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/WindowManager.java.diff?cvsroot=frysk&r1=1.29&r2=1.30

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/PickProcsDialog.java.diff?cvsroot=frysk&r1=1.1&r2=NONE

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/ProgramObserver.java.diff?cvsroot=frysk&r1=NONE&r2=1.1

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/ObserverManager.java.diff?cvsroot=frysk&r1=1.39&r2=1.40

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskCloneObserver.java.diff?cvsroot=frysk&r1=1.15&r2=1.16

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskExecObserver.java.diff?cvsroot=frysk&r1=1.22&r2=1.23

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskForkedObserver.java.diff?cvsroot=frysk&r1=1.38&r2=1.39

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskObserverRoot.java.diff?cvsroot=frysk&r1=1.13&r2=1.14

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskSyscallObserver.java.diff?cvsroot=frysk&r1=1.10&r2=1.11

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/monitor/observers/TaskTerminatingObserver.java.diff?cvsroot=frysk&r1=1.14&r2=1.15

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/sessions/DebugProcess.java.diff?cvsroot=frysk&r1=1.17&r2=1.18


*********************************************************************************************************************


Stepan's patches:

Modified files:
elfutils/backends: ChangeLog Makefile.am elfutils/tests : ChangeLog line2addr.c
Log message:
Restore our local changes to elfutils.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/backends/ChangeLog.diff?cvsroot=frysk&r1=1.4&r2=1.5

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/backends/Makefile.am.diff?cvsroot=frysk&r1=1.4&r2=1.5

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/ChangeLog.diff?cvsroot=frysk&r1=1.3&r2=1.4

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/line2addr.c.diff?cvsroot=frysk&r1=1.3&r2=1.4 


Modified files:
    tests          : ChangeLog Makefile.am
Log message:
    * Makefile.am: Move frysk2130/strace-clone-exec.sh to XFAIL_TESTS.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/tests/ChangeLog.diff?cvsroot=frysk&r1=1.76&r2=1.77

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/tests/Makefile.am.diff?cvsroot=frysk&r1=1.71&r2=1.72 


Modified files:
    elfutils/tests : ChangeLog Makefile.am
Log message:
    * Makefile.am: Add XFAIL_TEST = run-elflint-self.sh

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/ChangeLog.diff?cvsroot=frysk&r1=1.4&r2=1.5

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/Makefile.am.diff?cvsroot=frysk&r1=1.1.1.1&r2=1.2 



Modified files:
    elfutils/tests : ChangeLog Makefile.am
Log message:
    * Makefile.am: Add XFAIL_TEST = run-elflint-self.sh (frysk #2947)

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/ChangeLog.diff?cvsroot=frysk&r1=1.5&r2=1.6

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/elfutils/tests/Makefile.am.diff?cvsroot=frysk&r1=1.2&r2=1.3


Modified files:
frysk/gui : ChangeLog frysk/gui/test/dogtail_scripts: frysk_suite.in
Log message:
* test/dogtail_scripts/frysk_suite.in: Use "dogtail-run-headless -n".

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/ChangeLog.diff?cvsroot=frysk&r1=1.338&r2=1.339

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/test/dogtail_scripts/frysk_suite.in.diff?cvsroot=frysk&r1=1.11&r2=1.12


Modified files:
frysk/gui : ChangeLog frysk/gui/test/dogtail_scripts: frysk_suite.in
Log message:
* test/dogtail_scripts/frysk_suite.in: Use "dogtail-run-headless -n".
And do not check whether the accessibility is on;
dogtail-run-headless should temporarily switch it on, if necessary.

Modified files:
    .              : ChangeLog Makefile.am
Log message:
    * Makefile.am (TESTS_ENVIRONMENT): Add a comment.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/ChangeLog.diff?cvsroot=frysk&r1=1.78&r2=1.79

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/Makefile.am.diff?cvsroot=frysk&r1=1.62&r2=1.63


*********************************************************************************************************************


Len's Patches:

Modified files:
frysk/gui/test/dogtail_scripts: FryskHelpers.py ObserverHandler.py TestCreateObserversfromDataModel.py new_exec_custom_observer.xml
Log message:
Corrected logic errors - kept code in synch with GUIs.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/test/dogtail_scripts/FryskHelpers.py.diff?cvsroot=frysk&r1=1.41&r2=1.42

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/test/dogtail_scripts/ObserverHandler.py.diff?cvsroot=frysk&r1=1.13&r2=1.14

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/test/dogtail_scripts/TestCreateObserversfromDataModel.py.diff?cvsroot=frysk&r1=1.27&r2=1.28

http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-gui/frysk/gui/test/dogtail_scripts/new_exec_custom_observer.xml.diff?cvsroot=frysk&r1=1.3&r2=1.4




Phil Muldoon wrote:
I checked out each day from August 5th.

The test-suite works on 08/05, 08/06, 08/07 with cvs co corresponding to those dates.

It fails on 08/08 (ie cvs co -D "2 days ago"). So it looks like something changed on that date that caused some issues. So people who checked in on that day, should double check their patches and look for gotchas

Thanks

Phil

Mark Wielaard wrote:
On Thu, 2006-08-10 at 09:06 -0400, Elena Zannoni wrote:
Mark Wielaard writes:
 >  > We really need an autobuilder to catch such things early.

We really need people to run make check before checking stuff in.
Please folks be considerate to your fellow coders...

Unfortunately make check is not always very reliable. We are working on
some very different platforms. It can be that you are not seeing
failures on your platform, but others do see them on theirs. And it
seems make check is often randomly broken :{ Making it hard to see if
some failure was already there or that it was introduced by your new
code. I would love to have a zero make check fails checkin policy.

Although the fact that some tests take more than half an hour to run
make that a little hard in practise.
http://sources.redhat.com/ml/frysk/2006-q3/msg00160.html

Having an autobuilder on some canonical platform with public test
results would make comparing results between days/checkins easier at
least.

Cheers,

Mark




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]