This is the mail archive of the frysk@sources.redhat.com mailing list for the frysk project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Factory for ISA


On Fri, Jul 28, 2006 at 03:07:06PM +0200, Tim Moore wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Yao Qi wrote:
> > Now, A Factory is needed for LinuxTask to select ISA, and I separate
> > ISA selection from LinuxTask.java.
> > 
> > 2006-07-28  Yao Qi  <qiyaoltc@cn.ibm.com>
> > 
> >         * frysk/proc/LinuxTask.java: Move ISA selection to
> > IsaFactory.java and format it via Emacs.
> >         * frysk/proc/IsaFactory.java: New file.
> > 
> > Rebuild frysk on X86 and X86_64, and tested.
> > 
> > OK to commit? Thanks!
> > 
> This looks fine to me, with two comments:
> Please keep the GNU indentation. I couldn't tell you how to do this in
> Eclipse :), but there has been some mail about that recently.
In Emacs,
M-x c-set-style<ENTER>gnu<ENTER>  makes sence.  Thanks Tim for
reminding me this, :)
> 
> Your IsaFactory should probably be a singleton; no need to create a new
> one for each call to sendrecIsa.
Yes, you are right!  IsaFactory is another singleton.

Here are two patches modified per your comments above.  Could you have
a look?  Thanks!

-- 
Yao Qi

Attachment: IsaFactory.patch
Description: Text document

Attachment: LinuTask.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]