This is the mail archive of the
frysk@sources.redhat.com
mailing list for the frysk project.
Re: [patch] Factory for ISA
- From: Tim Moore <timoore at redhat dot com>
- To: frysk <frysk at sourceware dot org>
- Date: Fri, 28 Jul 2006 15:07:06 +0200
- Subject: Re: [patch] Factory for ISA
- References: <20060728093153.GB8035@GreenHouse.cn.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Yao Qi wrote:
> Now, A Factory is needed for LinuxTask to select ISA, and I separate
> ISA selection from LinuxTask.java.
>
> 2006-07-28 Yao Qi <qiyaoltc@cn.ibm.com>
>
> * frysk/proc/LinuxTask.java: Move ISA selection to
> IsaFactory.java and format it via Emacs.
> * frysk/proc/IsaFactory.java: New file.
>
> Rebuild frysk on X86 and X86_64, and tested.
>
> OK to commit? Thanks!
>
This looks fine to me, with two comments:
Please keep the GNU indentation. I couldn't tell you how to do this in
Eclipse :), but there has been some mail about that recently.
Your IsaFactory should probably be a singleton; no need to create a new
one for each call to sendrecIsa.
Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFEygv6eDhWHdXrDRURAsbRAKDN9usAPv+Q0zYzcioM59XGkEA/pwCg4r5w
+4+a98gAP+JHwXNWufGMEeU=
=+qli
-----END PGP SIGNATURE-----