This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] elf_begin sets elf_errno for cases that the file is completely unreadable
- From: Petr Machata <pmachata at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Thu, 11 Sep 2014 20:49:01 +0200
- Subject: Re: [PATCH] elf_begin sets elf_errno for cases that the file is completely unreadable
Roland McGrath <roland@hack.frob.com> writes:
>> if (unlikely (nread == -1))
>> - /* We cannot even read the head of the file. Maybe FILDES is associated
>> - with an unseekable device. This is nothing we can handle. */
>> - return NULL;
>> + {
>> + __libelf_seterrno (ELF_E_INVALID_FILE);
>> + /* We cannot even read the head of the file. Maybe FILDES is associated
>> + with an unseekable device. This is nothing we can handle. */
>> + return NULL;
>> + }
>
> That looks sensible, though I'd keep the comment at the top of the block.
Pushed with that fix.
Thanks,
PM