This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 1/4] Rewrite DWARF string functions using known-dwarf macros.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Sat, 04 Aug 2012 14:30:11 +0200
- Subject: Re: [PATCH 1/4] Rewrite DWARF string functions using known-dwarf macros.
> I don't like losing the "lo_user+%#x" cases.
Yeah, the original code was sometimes inconsistent in this regard.
I have rewritten the patch to consistently use "lo_user+%#x" in case
an unknown vendor extension is encountered.
> I also don't like "unknown_%#x". It should just be "%#x".
Again the original code inconsistent, sometimes just using "???"
to indicate something was wrong. I want there to be a clear indicator
that something is wrong/missing (just like in the case of an unknown
vendor extension). Which is why it is not just a bare "%#x" string.
Patch series rewritten and rebased, also on mjw/dwarfstrings branch.
Thanks,
Mark