Re: Cannot build trunk version

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 06 December 2011 04:14:27 Serge Pavlov wrote:
> --- a/configure.ac
> +++ b/configure.ac
>
> +if [ test -f libcpu/i386_dis.h ]; then

issues:
 - don't use the brackets as those are m4 quotes and will get removed, and if 
they weren't, it's invalid shell anyways:
	if [ test -f foo ] ; then
 - this doesn't work for out of tree builds as you need to be checking $srcdir
 - you probably should add an AC_MSG_WARNING that it was enabled, and why

> +if [ -z "$use_maintainer_mode" ]; then

test -z "$use_maintainer_mode"
-mike

Attachment: signature.asc
Description: PGP signature