This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [patch] Code cleanup: Unify {BE,LE}{32,64} in lib/system.h.
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Sat, 27 Apr 2013 21:26:26 +0200
- Subject: Re: [patch] Code cleanup: Unify {BE,LE}{32,64} in lib/system.h.
On Fri, 2013-04-26 at 17:03 +0200, Jan Kratochvil wrote:
> libdwfl/
> * link_map.c (BE32, BE64, LE32, LE64): Delete the definitions, move
> them to lib/system.h.
But then you do have to include system.h to pick up those definitions or
the file won't compile anymore. Fixed as follows:
commit 9efa9e6803992567576963f381fbd9cd6a7b9b86
Author: Mark Wielaard <mjw@redhat.com>
Date: Sat Apr 27 20:50:32 2013 +0200
libdwfl/link_map.c: #include system.h.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 0160534..42f720c 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-27 Mark Wielaard <mjw@redhat.com>
+
+ * link_map.c: #include system.h.
+
2013-04-26 Jan Kratochvil <jan.kratochvil@redhat.com>
* link_map.c (BE32, BE64, LE32, LE64): Delete the definitions, move
diff --git a/libdwfl/link_map.c b/libdwfl/link_map.c
index 19f92df..c6ec29c 100644
--- a/libdwfl/link_map.c
+++ b/libdwfl/link_map.c
@@ -29,6 +29,7 @@
#include <config.h>
#include "libdwflP.h"
#include "../libdw/memory-access.h"
+#include "system.h"
#include <byteswap.h>
#include <endian.h>