This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] readelf: Fix typo in a check in handle_relocs_rela
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 23 Sep 2014 14:25:48 +0200
- Subject: Re: [PATCH] readelf: Fix typo in a check in handle_relocs_rela
On Sun, 2014-09-14 at 01:03 +0200, Petr Machata wrote:
> - Testing shdr makes no sense, that pointer was dereferenced several
> times throughout the section. destshdr on the other hand is not
> tested at all.
>
> +2014-09-14 Petr Machata <pmachata@redhat.com>
> +
> + * readelf.c (handle_relocs_rela): Typo fix, test DESTSHDR properly.
Yes, seems obviously correct to me. The else branch would crash and burn
when trying to dereference destshdr->sh_name otherwise.
Thanks,
Mark