Re: Fix for elf_getdata/elf_flagdata on empty section

[Petr Machata <pmachata at redhat dot com>]

06.04.2010 08:52, Roland McGrath wrote:
> We don't have any other tests named for bug numbers, so let's not start
> that now.  Give it a meaningful name like bug-flagdata-nobits.
> 
> +int
> +main (__attribute__ ((unused)) int argc,
> +      __attribute__ ((unused)) char **argv)
> 
> main can just take (void) instead when they are unused.
> (Those two prototypes are both kosher in ISO C.)
> 
> +  int fd = open64 ("/proc/self/exe", O_RDONLY);
> 
> Bletch.  I don't like either relying on Linux /proc magic here, or assuming
> that the binary will tickle the case.  Of the many existing test files,
> some have a SHT_NOBITS section and so should tickle the bug.  So just pick
> one and do a run-bug-flagdata-nobits.sh that uses it.
> 
> When you've cleaned up those nits with the test, please push both changes
> to master.

It's there.

PM

Attachment: signature.asc
Description: PGP signature