This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] doubled words
- From: Mark Wielaard <mjw at redhat dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Sat, 16 Apr 2011 07:56:21 -0400
- Subject: Re: [PATCH] doubled words
> On Sat, Apr 16, 2011 at 06:12, Mark Wielaard <mjw@redhat.com> wrote:
> > I read through the patch and the changes all seem fine to me.
>
> But it's not. The last change for ldgeneric.c should fix up the whole
> comment and not change just the duplication. If these types of
> changes are made then they better be complete.
Could you be a bit more specific? I reread the comment and the following
code, and the comment seems to describe what it does. I might be missing
something, but I don't immediately see what.
> Aside, changes without any code changes shouldn't pollute the
> ChangeLog files.
Yeah, it would be bad if there were constant comment "cleanups".
But I assume this is a one time thing.
Thanks,
Mark