This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Replace libdw nested functions with macros, part 1.
- From: Chih-Hung Hsieh <chh at google dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Tue, 15 Sep 2015 15:59:55 -0700
- Subject: Re: [PATCH] Replace libdw nested functions with macros, part 1.
Does the new walk_children look right to you?
That style is similar to what I would use when I need to factor out code in
large C functions. It should be general enough to replace all nested
functions in elfutils.
On Tue, Sep 15, 2015 at 3:46 PM, Roland McGrath <roland@hack.frob.com>
wrote:
> A lot of these are longer than I'd like to see for macros. Let's commit
> all the ones where it's pretty straightforward to make them static
> functions and then see what's left.
>
Does the newÂ
walk_children look right to you?That style is similar to what I would use when I need to factor out code in large C functions. It should be general enough to replace all nested functions in elfutils.
On Tue, Sep 15, 2015 at 3:46 PM, Roland McGrath
<roland@hack.frob.com> wrote:
A lot of these are longer than I'd like to see for macros. Let's commit
all the ones where it's pretty straightforward to make them static
functions and then see what's left.