This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Replace libdw nested functions with macros, part 1.


Does the new walk_children look right to you?
That style is similar to what I would use when I need to factor out code in
large C functions. It should be general enough to replace all nested
functions in elfutils.



On Tue, Sep 15, 2015 at 3:46 PM, Roland McGrath <roland@hack.frob.com>
wrote:

> A lot of these are longer than I'd like to see for macros.  Let's commit
> all the ones where it's pretty straightforward to make them static
> functions and then see what's left.
>
Does the new walk_children look right to you?
That style is similar to what I would use when I need to factor out code in large C functions. It should be general enough to replace all nested functions in elfutils.



On Tue, Sep 15, 2015 at 3:46 PM, Roland McGrath <roland@hack.frob.com> wrote:
A lot of these are longer than I'd like to see for macros.  Let's commit
all the ones where it's pretty straightforward to make them static
functions and then see what's left.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]