This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/6] readelf: Extend -z to dumping hex and string sections (-x and -p).


On Thu, 2015-10-22 at 15:08 -0700, Roland McGrath wrote:
> > +    N_("Show compression information for compressed sections (when used with -S). Decompress section before dumping data (when used with -p or -x)"), 0 },
> >    { NULL, 0, NULL, 0, NULL, 0 }
> 
> I'd make this a single sentence with a semicolon.

Changed it to:

-z, --decompress       Show compression information for compressed
                       sections (when used with -S); decompress section
                       before dumping data (when used with -p or -x)

> Otherwise fine assuming that binutils readelf -z has the same semantics.

Yes, binutils readelf -z has the same semantics for dumping uncompressed
sections. For section details binutils readelf only shows information
for SHF_COMPRESSED sections, not for gnu style compressed sections. But
I think showing it for both makes more sense.

> It might be nice to make the section introduction more verbose, e.g.
> "... contains %u bytes (%u bytes uncompressed) ..." rather than just
> "... contains %u bytes [%u] ..."

Also changed.

The (rebased) patch can be found on mjw/compress branch in git.

I will now work on adding an elf-[de]compress utility and update the
interfaces based on the solaris feedback.

Thanks,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]