This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Strip on mips


On Sun, Aug 26, 2012 at 04:17:36PM +0200, Kurt Roeckx wrote:
> On Thu, Aug 23, 2012 at 04:42:16PM -0700, Roland McGrath wrote:
> > Probably the best way to write the MIPS backend implementation is:
> > 
> > 	bool
> > 	mips_debugscn_p (const GElf_Shdr *shdr, const char *name)
> > 	{
> > 	  if (shdr != NULL && shdr->sh_type == SHT_MIPS_DWARF)
> > 	    return true;
> > 	  return (*generic_debugscn_p) (shdr, name);
> > 	}
> 
> Does that mean generic_debugscn shouldn't check the shdr?  Because
> now it would check it and then fail for mips because it's not
> SHT_PROGBITS.
> 
> I guess I'm missing something.

Can you comment on this?

Do you think it might be better to have a new hook instead,
that uses the current one?


Kurt


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]