Re: New test for elf_flag{data,ehdr,elf,phdr}

[Mark Wielaard <mjw at redhat dot com>]

Hi Marek,

On Mon, 2011-05-09 at 15:41 +0200, Marek Polacek wrote:
> On 05/09/2011 01:20 PM, Mark Wielaard wrote:
> > How are you measuring coverage?
> 
> Using the lcov.  Here's what I do:
> 
> $ ./configure --enable-gcov
> $ make -j4 check
> $ lcov --directory . --capture --output-file blah.info
> $ genhtml blah.info
> $ firefox index.html

Thanks for the description. I had some trouble with lcov not handling
"<built-in>" correctly. Which created an error message:
<built-in>:cannot open source file
geninfo: ERROR: cannot read <built-in>.gcov!
The issue prevented a full report, so src/ for example for excluded.
I created a patch:
https://bugzilla.redhat.com/show_bug.cgi?id=706040

> Which reminds me, do you (or anyone) please have a suggestion what should I test
> next?

With the above patch you can get also src/ coverage. That suggests some
tests that could be added. For example from inspecting the strip.c
coverage it is clear that things like the remove comments, ar
processing, preserve date, Alpha and S390 64-bit SHT_HASH entries and
extended SHN_XINDEX stuff is never tested. I think higher level tests
that exercise the tools are most useful. It shouldn't even be too hard.
Just generate an elf file containing any of the above and just have a
test run it through the various tools.

Cheers,

Mark