This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] No nested functions in dwarf_get{srclines,scopevar}
- From: Chih-Hung Hsieh <chh at google dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Mon, 02 Nov 2015 15:58:20 -0800
- Subject: Re: [PATCH] No nested functions in dwarf_get{srclines,scopevar}
Mark, thanks for integrating a few of my previous patches to eliminate
nested functions.
I wonder if you have looked at this new 0002*patch and some other patches I
sent related to the move of nested functions. To help you find the other
patches, I will email you the list separately.
Thanks.
On Wed, Oct 21, 2015 at 4:04 PM, Chih-hung Hsieh <chh@google.com> wrote:
> Mark,
>
> The latest release 0.164 looked good to me. I have merged it into Android
> source tree.
> I am sending more patches to fix nested functions to compile with clang on
> Android.
> Changes for one or two files are put into a patch and tested separately
> so it should be okay to merge the patches in any order.
>
> I hope these many smaller patches are easier to merge for you.
> Please let me know if you prefer any different style.
> Thanks.
>
>
> On Wed, Oct 14, 2015 at 12:44 PM, Mark Wielaard <mjw@redhat.com> wrote:
>
>> On Tue, 2015-10-13 at 15:39 -0700, Chih-Hung Hsieh wrote:
>> > Move nested functions in libdw/dwarf_get{scopevar,srclines}.c
>> > to file scope to compile with clang/llvm.
>>
>> Since I would like to get a new release out on Friday and have a little
>> time to test things I am not immediately pushing these patches right
>> now. They are probably fine, but I like to look over them first. And
>> since they are somewhat large I am afraid we might introduce some subtle
>> bug right before the release. I'll get to them as soon as the release is
>> done on Friday.
>>
>
>
Mark, thanks for integrating a few of my previous patches to eliminate nested functions.
I wonder if you have looked at this new 0002*patch and some other patches I sent related to the move of nested functions. To help you find the other patches, I will email you the list separately.
Thanks.
On Wed, Oct 21, 2015 at 4:04 PM, Chih-hung Hsieh
<chh@google.com> wrote:
Mark,
The latest release 0.164 looked good to me. I have merged it into Android source tree.
I am sending more patches to fix nested functions to compile with clang on Android.
Changes for one or two files are put into a patch and tested separately
so it should be okay to merge the patches in any order.
I hope these many smaller patches are easier to merge for you.
Please let me know if you prefer any different style.
Thanks.
Â
On Wed, Oct 14, 2015 at 12:44 PM, Mark Wielaard
<mjw@redhat.com> wrote:
On Tue, 2015-10-13 at 15:39 -0700, Chih-Hung Hsieh wrote:
> Move nested functions in libdw/dwarf_get{scopevar,srclines}.c
> to file scope to compile with clang/llvm.
Since I would like to get a new release out on Friday and have a little
time to test things I am not immediately pushing these patches right
now. They are probably fine, but I like to look over them first. And
since they are somewhat large I am afraid we might introduce some subtle
bug right before the release. I'll get to them as soon as the release is
done on Friday.