This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: Rerequesting dwarf_tag on a die with invalid abbrev code
- From: Roland McGrath <roland at hack dot frob dot com>
- To: elfutils-devel at lists dot fedorahosted dot org
- Date: Wed, 16 Mar 2011 14:27:23 -0700
- Subject: Re: Rerequesting dwarf_tag on a die with invalid abbrev code
> <pedantic> The comment and the return inside the while loop was
> confusing me at first. It would maybe be slightly easier on the reader
> to replace the "return DWARF_END_ABBREV;" with a "break;", so that your
> "at the end already" logic triggers always instead of only on the second
> (or third, etc.) call. </pedantic>
I'm looking at
http://git.fedorahosted.org/git/?p=elfutils.git;a=commitdiff;h=bd1d16c3a17c227d1379df10e97f6c7865ad1440
and I can't see what you're referring to.
Are we talking about the same change?
Thanks,
Roland