This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libebl: Don't install libebl.a, libebl.h and remove backends from spec.


Hi Mark,

On Wed, Jan 08, 2020 at 03:09:32PM +0100, Mark Wielaard wrote:
> On Thu, 2020-01-02 at 03:02 +0300, Dmitry V. Levin wrote:
> > On Thu, Aug 29, 2019 at 11:43:58PM +0200, Mark Wielaard wrote:
> > > All archive members from libebl.a are now in libdw.a. We don't generate
> > > separate backend shared libraries anymore. So remove them from the
> > > elfutils.spec file.
> > > 
> > > diff --git a/libebl/ChangeLog b/libebl/ChangeLog
> > > index 6ba3a02b..4da7eeeb 100644
> > > --- a/libebl/ChangeLog
> > > +++ b/libebl/ChangeLog
> > > @@ -1,3 +1,8 @@
> > > +2019-08-29  Mark Wielaard  <mark@klomp.org>
> > > +
> > > +	* Makefile.am (noinst_LIBRARIES): Add libebl.a.
> > > +	(noinst_HEADERS): Add libebl.h.
> > 
> > (pkginclude_HEADERS): Remove.
> 
> Ah, yes, sorry missed that one.
> 
> > > @@ -62,6 +59,6 @@ libebl_a_SOURCES = eblopenbackend.c
> > > eblclosebackend.c eblreloctypename.c \
> > >  libebl_pic_a_SOURCES =
> > >  am_libebl_pic_a_OBJECTS = $(libebl_a_SOURCES:.c=.os)
> > >  
> > > -noinst_HEADERS = libeblP.h ebl-hooks.h
> > > +noinst_HEADERS = libebl.h libeblP.h ebl-hooks.h
> > >  
> > >  MOSTLYCLEANFILES = $(am_libebl_pic_a_OBJECTS)
> > 
> > After this part of the change libebl.h is no longer installed, but
> > it's included by libasm.h which is still installed.
> > 
> > This has to be fixed somehow, but I'm not sure whether libebl.h should be
> > reinstated, libasm.h should stop to include it, or libasm.h should stop
> > to be installed.
> 
> Urgh. Missed that too.
> 
> Even if you could use libasm.h, linking with libasm always was kind of
> useless since there was no supported way to create an Ebl handle.
> Unless you statically linked with libebl, which was never supported and
> might still not work since it might conflict with changes in the libebl
> linked to by libasm/libdw.
> 
> In fact our own elfutils.spec doesn't even install it. But sadly some
> distros (including Fedora... my fault) do install it.
> 
> Short term I propose the attached patch.

Thanks, it works: the packaging check that used to complain about
compilation error in installed libasm.h turns green when this patch
is applied.


-- 
ldv


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]