This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] lib + libdw: Add and use a concurrent version of the dynamic-size hash table.


Hi Jonathon,

On Mon, 2019-11-11 at 17:38 -0600, Jonathon Anderson wrote:
> > Since the memblocks are per thread, it seems we could easily back out
> > an allocation we don't need as long as the thread hasn't done any 
> > other
> > allocation from the memblock. What do you think of the attached patch?
> 
> Looks good to me.
> 
> > It is a bit hard to test without a massively parallel testcase where
> > things collide a lot. Since you have one, could you try this out?
> 
> Everything seems to work fine on this end.
> 
> (Plus, if you replace the `Abbrev_find == NULL` with `1`, you can make 
> everything collide. Which I did too, and it still works fine.)

O nice trick. Just build and ran a distcheck with this to be sure
things still work.

Thanks for your review and testing. Pushed to master.

Cheers,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]