This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RISC-V: Add untested 32-bit core file support.


On Sat, Jan 12, 2019 at 04:37:51PM -0800, Jim Wilson wrote:
> On Sat, Jan 12, 2019 at 2:29 PM Mark Wielaard <mark@klomp.org> wrote:
> > > static const Ebl_Register_Location prstatus_regs[] =
> > >    {
> > > -    { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
> > > +    { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
> > >    };
> >
> > Should that be .bits = BITS ?
> 
> Yes, sorry, I was looking at the offset field and completely missed
> the bits member at the end.  Do you want me to submit an updated
> patch?

I fixed it up and pushed the commit. It looks fine otherwise.

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]