[Bug libelf/23884] error: ‘__elf32_msize’ specifies less restrictive attribute than its target ‘elf32_fsize’: ‘const’ [-Werror=missing-attributes]

["mark at klomp dot org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=23884

Mark Wielaard <mark at klomp dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2018-11-15
     Ever confirmed|0                           |1

--- Comment #2 from Mark Wielaard <mark at klomp dot org> ---
No, of course gcc is right.

fsize is declared in libelf.h as:

/* Return size of array of COUNT elements of the type denoted by TYPE
   in the external representation.  The binary class is taken from ELF.
   The result is based on version VERSION of the ELF standard.  */
extern size_t elf32_fsize (Elf_Type __type, size_t __count,
                           unsigned int __version)
       __const_attribute__;
/* Similar but this time the binary calls is ELFCLASS64.  */
extern size_t elf64_fsize (Elf_Type __type, size_t __count,
                           unsigned int __version)
       __const_attribute__;

But msize is declared in libelfP.h as:

/* The libelf API does not have such a function but it is still useful.
   Get the memory size for the given type.

   These functions cannot be marked internal since they are aliases
   of the export elfXX_fsize functions.*/
extern size_t __elf32_msize (Elf_Type __type, size_t __count,
                             unsigned int __version);
extern size_t __elf64_msize (Elf_Type __type, size_t __count,
                             unsigned int __version);

So the obvious fix is:

diff --git a/libelf/libelfP.h b/libelf/libelfP.h
index fa6d55d..9f3e8e9 100644
--- a/libelf/libelfP.h
+++ b/libelf/libelfP.h
@@ -461,9 +461,9 @@ extern Elf_Type __libelf_data_type (Elf *elf, int sh_type,
G
    These functions cannot be marked internal since they are aliases
    of the export elfXX_fsize functions.*/
 extern size_t __elf32_msize (Elf_Type __type, size_t __count,
-                            unsigned int __version);
+                            unsigned int __version) __const_attribute__;
 extern size_t __elf64_msize (Elf_Type __type, size_t __count,
-                            unsigned int __version);
+                            unsigned int __version) __const_attribute__;


 /* Create Elf descriptor from memory image.  */

-- 
You are receiving this mail because:
You are on the CC list for the bug.