This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] Handle GNU Build Attribute ELF Notes.
- From: Nick Clifton <nickc at redhat dot com>
- To: Mark Wielaard <mark at klomp dot org>, elfutils-devel at sourceware dot org
- Date: Tue, 13 Nov 2018 11:56:35 +0000
- Subject: Re: [PATCH] Handle GNU Build Attribute ELF Notes.
- Organization: Red Hat
- References: <1542065698-4660-1-git-send-email-mark@klomp.org>
Hi Mark,
Well I for one am very happy to see this patch proposed for elfutils... :-)
> + /* There might or might not be a pair of addresses in the desc. */
FYI - There was an old version of the Watermark specification that only put
one address into the note's desc field. This version was never used in
production binaries, so it is unlikely that such notes will ever be found in
the wild.
Anyway although I am not an official elfutils reviewer the patch looks great
to me. I hope that it will be accepted into the sources.
Cheers
Nick