This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH] strip, unstrip: Handle SHT_GROUP correctly.
- From: Mark Wielaard <mark at klomp dot org>
- To: elfutils-devel at sourceware dot org
- Date: Wed, 17 Oct 2018 14:02:43 +0200
- Subject: Re: [PATCH] strip, unstrip: Handle SHT_GROUP correctly.
- References: <1539420386-10040-1-git-send-email-mark@klomp.org>
On Sat, 2018-10-13 at 10:46 +0200, Mark Wielaard wrote:
> The usage of annobin in Fedora showed a couple of bugs when using
> eu-strip and eu-unstrip on ET_REL files that contain multiple group
> sections.
>
> When stripping we should not remove the SHF_GROUP flag from sections
> even if the group section itself might be removed. Either the section
> itself gets removed, and so the flag doesn't matter. Or it gets moved
> together with the group section into the debug file, and then it
> still
> needs to have the flag set. Also we would "renumber" the section
> group
> flag field (which isn't a section index, and so shouldn't be
> changed).
>
> Often the group sections have the exact same name (".group"), flags
> (none) and sometimes the same sizes. Which makes matching them hard.
> Extract the group signature and compare those when comparing two
> group sections.
Pushed to master.