This is the mail archive of the elfutils-devel@sourceware.org mailing list for the elfutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3] Use fallthrough attribute

From: Mark Wielaard <mark at klomp dot org>
To: Joshua Watt <jpewhacker at gmail dot com>
Cc: elfutils-devel at sourceware dot org
Date: Sat, 10 Feb 2018 03:26:43 +0100
Subject: Re: [PATCH v3] Use fallthrough attribute
Authentication-results: sourceware.org; auth=none
References: <20180208233010.11395-1-JPEWhacker@gmail.com> <20180209162718.5905-1-JPEWhacker@gmail.com>

Hi Joshua,

On Fri, Feb 09, 2018 at 10:27:18AM -0600, Joshua Watt wrote:
> Use __attribute__ ((fallthrough)) to indicate switch case fall through
> instead of a comment. This ensure that the fallthrough warning is not
> triggered even if the file is pre-processed (hence stripping the
> comments) before it is compiled.
> 
> The actual fallback implementation is hidden behind a FALLBACK macro in
> case the compiler doesn't support it.
> 
> Finally, the -Wimplict-fallthrough warning was upgraded to only allow
> the attribute to satisfy it; a comment alone is no longer sufficient.

Thanks, this look good.
I added ChangeLog entries and pushed it to master.

Cheers,

Mark

Follow-Ups:
- Re: [PATCH v3] Use fallthrough attribute
  - From: Frank Ch. Eigler

References:
- [PATCH v2] Add fallthrough attributes
  - From: Joshua Watt
- [PATCH v3] Use fallthrough attribute
  - From: Joshua Watt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]