This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
Re: [PATCH 4/5] Add i386 frame pointer unwinder.
- From: Ulf Hermann <ulf dot hermann at qt dot io>
- To: Mark Wielaard <mark at klomp dot org>, <elfutils-devel at sourceware dot org>
- Date: Tue, 25 Apr 2017 15:04:02 +0200
- Subject: Re: [PATCH 4/5] Add i386 frame pointer unwinder.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=qt.io;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1X9iRJJP7Ho5dBNgT4/GYz8FyDom8rv1lNdz96DHbG4=; b=HGwfcSyhu/gmu3Ot+qIugrtJbfVZGNOd4rku+h3W3nHF8eUaT1kEdS4CPYffmvQXe2ZaUZ5fX10vzC22f45tEq+eFDzBXczrlfaTpuG65V5SpXhVT1WePHh3Ge3OZZx5SFJOl7TDVtTmauOF7lyh8TqTkarnJCKXzouhfbgl0go=
- References: <1493124006.31726.33.camel@klomp.org> <1493124579-21017-1-git-send-email-mark@klomp.org> <1493124579-21017-4-git-send-email-mark@klomp.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 04/25/2017 02:49 PM, Mark Wielaard wrote:
> Add a simple i386_unwind.c frame pointer unwinder as fallback if DWARF/CFI
> unwinding fails.
Looks good to me. The logic could be relaxed a bit so that failure to e.g. write the new value for sp would not be fatal. Then we might be able to unwind even more frames. But refusing to unwind obviously broken frames is acceptable, too.
Ulf