This is the mail archive of the
elfutils-devel@sourceware.org
mailing list for the elfutils project.
[PATCH] Check for existence of GNU-style strerror_r
- From: Ulf Hermann <ulf dot hermann at qt dot io>
- To: elfutils-devel at sourceware dot org
- Date: Wed, 22 Feb 2017 15:18:44 +0100
- Subject: [PATCH] Check for existence of GNU-style strerror_r
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=ulf dot hermann at qt dot io;
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qtcompany.onmicrosoft.com; s=selector1-qt-io; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vp0CG44H80IamWlQQU96YLWcBjLbIz2N0725KlK08Tc=; b=J41/CLqrIjYYf+s1SjVTxAs2Kd+0A4Jy49HinJK/qq8AesPPxCA4aDYB4cQRxh9htzNkykXet73+VnVA1sm/m+shalB+GwxlS8yyfebGq4vyIHqbc52CtYHM5f8XJE8gHg1CJAz5b6Zx9tRI55WAwuUnId+oj7QRTpsFt03nwOw=
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
If we don't have it, we don't translate system error codes to strings in
dwfl_error.c.
Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
ChangeLog | 4 ++++
configure.ac | 2 ++
libdwfl/ChangeLog | 5 +++++
libdwfl/dwfl_error.c | 4 ++++
4 files changed, 15 insertions(+)
diff --git a/ChangeLog b/ChangeLog
index dd9b9ac..1acc8ba 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
+ * configure.ac: Check for strerror_r and its variants.
+
+2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
+
* configure.ac: Add check for fputs_unlocked.
2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
diff --git a/configure.ac b/configure.ac
index 8119e07..ce40539 100644
--- a/configure.ac
+++ b/configure.ac
@@ -309,6 +309,8 @@ AC_CHECK_DECLS([fputs_unlocked],[],[],
[#define _GNU_SOURCE
#include <stdio.h>])
+AC_FUNC_STRERROR_R
+
AC_CHECK_LIB([stdc++], [__cxa_demangle], [dnl
AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling is enabled])])
AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" = "xyes")
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index f5921dc..1a23136 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,5 +1,10 @@
2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
+ * dwfl_error.c: If we don't have a strerror_r returning a char*,
+ output a less useful message in case of a system error.
+
+2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
+
* dwfl_module_getsrc_file.c: Include system.h.
2017-02-22 Ulf Hermann <ulf.hermann@qt.io>
diff --git a/libdwfl/dwfl_error.c b/libdwfl/dwfl_error.c
index 7bcf61c..7733496 100644
--- a/libdwfl/dwfl_error.c
+++ b/libdwfl/dwfl_error.c
@@ -154,7 +154,11 @@ dwfl_errmsg (int error)
switch (error &~ 0xffff)
{
case OTHER_ERROR (ERRNO):
+#ifdef STRERROR_R_CHAR_P
return strerror_r (error & 0xffff, "bad", 0);
+#else
+ return "Unkown error. See errno";
+#endif
case OTHER_ERROR (LIBELF):
return elf_errmsg (error & 0xffff);
case OTHER_ERROR (LIBDW):
--
2.1.4