Re: [PATCH] Error out on DW_AT_location with invalid encoding

[Jakub Jelinek <jakub@redhat.com>]

On Thu, Mar 07, 2019 at 09:23:19AM +0100, Tom de Vries wrote:
> On 07-03-19 08:55, Jakub Jelinek wrote:
> > On Thu, Mar 07, 2019 at 08:22:42AM +0100, Tom de Vries wrote:
> >> Hi,
> >>
> >> When processing a file containing an DW_AT_location with encoding DW_FORM_addr,
> > 
> > What kind of generator generates that?  Ugh.
> 
> AFAICT it's the result of generating a .s file from a .c file and then
> hand-editing the debug info (
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/testsuite/gdb.dwarf2/dw2-restrict.S;h=7108b86ec109ce5a1bd299e2c36696a12024e0d5;hb=HEAD
> ):
> ...
>         .byte   16                      # DW_AT_stmt_list
>         .byte   1                       # DW_FORM_addr
> ...

Is it worth bothering with that then?  Shouldn't just gdb be fixed?
Or is it intentional that the test tests how it deals with invalid DWARF?

I mean, dwz has over hundred asserts and many of them will fail if fed
complete garbage.  Do we want to turn them all into errors?

	Jakub