Re: [ANNOUNCEMENT] TEST: Cygwin 3.1.0-0.3

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

On Aug 31 03:20, Takashi Yano wrote:
> On Fri, 30 Aug 2019 09:55:23 +0200
> Corinna Vinschen wrote:
> > On Aug 29 22:15, Biswapriyo Nath wrote:
> > > On Thursday, August 29, 2019, Corinna Vinschen <corinna-cygwin@cygwin.com>
> > > 1a. In fhandler_pty_mater::ioctl function, shouldn't the function pointer
> > > be checked before use? Also what the FIXME says, isn't clear. Any hint?
> > 
> > Yeah, right.  What happens on pre-W10 1809 systems?  They probably
> > crash on TIOCSWINSZ.  See below.
> 
> This code is protected by
> if (getPseudoConsole () && ...
> that is, pseudo console handle is set only if CreatePseudoConsole()
> successes. In pre-W10 1809, since pseudo console handle is not set,
> this code is not reached. However, it is better to check before
> call as you suggest.
> 
> What is meant in FIXME comment:
> ResizePseudoConsole() needs handle to pseudo console. This handle is
> valid only in the process which created it. If ioctl(TIOCSWINSZ, ...)
> is called from other process, it fails. I had tried DuplicateHandle(),
> but it did not work. Therefore, ResizePseudoConsole() is called
> only if ioctl() is called from PTY master process. Similarly,
> ClosePseudoConsole() can work only in the master process.

Ah, that makes sense.

> > > 1b. GetModuleHandle and GetProcessHeap is called several times. Wouldn't be
> > > it easier to get all the pseudo console function pointers in one
> > > constructor?
> > 
> > In terms of GetModuleHandle/GetProcAddress the right thing to do is to
> > use the autoload feature, i.e., add the functions to autoload.cc like
> > this:
> > 
> >   LoadDLLfuncEx (ClosePseudoConsole, 4, kernel32, 1)
> >   LoadDLLfuncEx (CreatePseudoConsole, 20, kernel32, 1)
> >   LoadDLLfuncEx (ResizePseudoConsole, 8, kernel32, 1)
> > 
> > If the function call returns FALSE with GetLastError() ==
> > ERROR_PROC_NOT_FOUND, then the function is not available.
> > 
> > Takashi, I didn't actually notice the usage of the Windows heap here.
> > The usual method is to use a tls_pbuf buffer, and rather than
> > using MultiByteToWideChar/WideCharToMultiByte, use sys_mbstowcs/
> > sys_wcstombs.
> > 
> > Also, can you please change the camelback names in class tty_min to
> > underscored writing, e.g., term_codepage rather than TermCodePage?
> 
> OK. I will revised the code followed to your advice.
> 
> First, I would like to fix some bugs and will post a patch.
> Second, I will revise the coding style.
> 
> May I post them as indivisual patches?

That would be great.  Individual patches with each of them fixing just
a single problem are definitely preferrable over bulk patches.  Please
send them to the cygwin-patches mailing list.

>  I also suppose the patch should be against the v9 patch, right?

Well, actually they should be against current git master.  Incidentally
that's your v9 patch ;)


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

Attachment: signature.asc
Description: PGP signature