This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Error Installing Cygwin (setup-x86_64.exe & setup-x86) - No setup.ini.sig found.

On 10/18/2015 9:47 AM, Ken Brown wrote:
On 10/18/2015 9:28 AM, Achim Gratz wrote:
Ken Brown writes:
Are you saying you've never tested local installs without the -m

No, I'm saying that the "-m" switch should reduce the possibility of
setup doing something unwanted, because it eliminates the possibility of
it switching into ad-hoc mode (where it searches the subdirs for
setup.ini and package files to full depth).

If so, that explains why you haven't been able to reproduce
the problems that several of us have reported.  I just verified that
setup does indeed correctly descend into subdirectories with the -m

That still doesn't tell me what about your mirror directories triggers
it to not use local mirror mode when not using that switch.  If the
directory structure is correct that is in theory impossible since it
tries mirror mode first and only if it doesn't find a useable setup file
that way would it fall back to ad-hoc mode.  Please run the commands in
my other replay to David Stacey and tell me the result.

$ find -mindepth 1 -maxdepth 1 -name $arch | \
 > xargs -I: sh -c 'for f in :/setup.{xz,bz2,ini}; \
 > do [ -e $f ] && { echo $f ; break; } done' && \
 > find -mindepth 2 -maxdepth 2 -name $arch | \
 > xargs -I: sh -c 'for f in :/setup.{xz,bz2,ini}; \
 > do [ -e $f ] && { echo $f ; break; } done'

Just for the record, I did a git bisection, showing (unsurprisingly) that the first bad commit is one of the following two:

commit 18837afa64984e98476401e99dcd772970cf9736
Author: Achim Gratz <Stromeko@Stromeko.DE>
Date:   Sat Jul 11 21:58:30 2015 +0200

    Refactor setup search and implement XZ compressed setup files

        * Construct setup_ext_list from array until we can use
        C++11 aggregate initializers.  Clean up function parenthesis.
        (decompress_ini): Refactored for use from do_local_ini and
        do_remote_ini.  Change outdated comment about setup.ini
        uncompressed size.
        (check_ini_sig): Factor out signature check.
        (fetch_remote_ini): Refactored for use from do_remote_ini.
        (do_local_ini): Iterate over search results in found_ini_list.
        Use decompress_ini and check_ini_sig.
        (do_remote_ini): Iterate over known setup file extensions from
        setup_ext_list with early-out semantics, preferring ".xz" over
        ".bz2" over ".ini" extension.  Use fetch_remote_ini and
        * ini.h: Remove unused macros.
        * Remove, the search is already done by
        SetupFindVisitor in do_from_local_dir.
        * Ditto.
        * (@SETUP@_SOURCES): Ditto.

commit 35addac4a65a1d70ab02b8d175f71efa83cf74ba
Author: Achim Gratz <Stromeko@Stromeko.DE>
Date:   Wed Jul 1 21:36:12 2015 +0200

    Correct local directory search

        * Remove unused includes.  Add global found_ini_list
        to record the search result.
        (SetupFindVisitor): Make setup.{ini,bz2,xz} known and provide bool
        private variables to record whether we found them.  Another bool
        inidir to indicate whether we are currently inside a directory
        where setup.ini files should exist.
        (SetupFindVisitor::visitFile): When inidir is true, check if a
        setup file with one of the known extensions was found and set the
        corresponding bool variables.
            (SetupFindVisitor::visitDirectory): Set inidir when appropriate.
        Recurse into directories only if they are potential mirror dirs,
        based on level. Truncate search and recurse into inidir.  Record
        any setup files in found_ini_list while preferring ".xz" over
        ".bz2" over ".ini" extension.
        (SetupFindVisitor::operator bool): Return true when found_ini_list
        is non-empty.
        (do_from_local_dir): Restrict search to either a single mirror
        hierarchy or multiple mirror hierarchy; setup files directly in
        local directory or mixed hierarchies are no longer recognized.
        The setup files must be present in an architecture dependent
        directory of "x86/" or "x86_64/", either in the local directory
        for single mirror or one level down for multiple mirrors.

    This patch already finds setup.xz files, but the code to deal with
    them will be in a later patch.  The current code re-does the search
    and ignores the results from here.

setup didn't build after 35addac, so I can't pin it down further. Unfortunately, those two commits seem to involve fairly substantial changes.

As test case for the bisection, I used step 4 of the recipe I posted in


Problem reports:
Unsubscribe info:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]