This is the mail archive of the
cygwin
mailing list for the Cygwin project.
Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
- From: Takashi Yano <takashi dot yano at nifty dot ne dot jp>
- To: cygwin at cygwin dot com
- Date: Wed, 25 Mar 2015 20:20:46 +0900
- Subject: Re: TIOCPKT mode of PTY is broken if ONLCR bit is cleared.
- Authentication-results: sourceware.org; auth=none
- References: <20150228143653 dot ab0a6bf854db294105e1d5f3 at nifty dot ne dot jp> <20150228135947 dot GZ11124 at calimero dot vinschen dot de> <20150302210508 dot 1be5c1ed4753508431842913 at nifty dot ne dot jp> <20150318145854 dot GC2368 at calimero dot vinschen dot de> <20150319074942 dot 6c18c8fe0199037f028687dd at nifty dot ne dot jp> <20150319083451 dot GA8398 at calimero dot vinschen dot de> <20150320191232 dot GJ2368 at calimero dot vinschen dot de> <20150321104031 dot 9dc198eb8aa4e7652e0a7a51 at nifty dot ne dot jp> <20150323100823 dot GE3017 at calimero dot vinschen dot de>
Hi Corinna,
On Mon, 23 Mar 2015 11:08:23 +0100
Corinna Vinschen <corinna-cygwin@cygwin.com> wrote:
> With this out of the way, I'm just looking through your patch and it
> looks good to me. I have only a few minor style nits:
>
> + rc ++;
>
> No space between the variable and the increment operator, please.
>
> + if ((get_ttyp ()->ti.c_oflag & ONOCR) && get_ttyp ()->column == 0)
>
> Please try to keep lines <= 80 chars:
>
> + if ((get_ttyp ()->ti.c_oflag & ONOCR)
> + && get_ttyp ()->column == 0)
Thank you for checking my patch.
> However, due to the changes in fhandler_tty.cc, this patch doesn't
> apply cleanly anymore. Any chance you could resend it (ideally to the
> cygwin-patches ML) diff'ed against git HEAD?
I will post a revised patch to cygwin-patches ML soon.
Thank you in advance.
--
Takashi Yano <takashi.yano@nifty.ne.jp>
--
Problem reports: http://cygwin.com/problems.html
FAQ: http://cygwin.com/faq/
Documentation: http://cygwin.com/docs.html
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple