This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mintty needs a patch

Am 15.02.2015 um 10:27 schrieb Corinna Vinschen:
On Feb 14 23:10, Tony Kelman wrote:
I was trying to build mintty from its src package today. As a heads-up
for whoever next tries to build the package, I get the following error
on either 32 or 64 bit:

gcc -c -MMD -MP -DTARGET=x86_64-pc-cygwin -DNDEBUG -std=gnu99 -include std.h
-Wall -Wextra -Wundef -Werror -mtune=atom -fomit-frame-pointer -O2 wintext.c
windres --preprocessor 'gcc -E -xc -DRC_INVOKED -MMD -MP
-DTARGET=x86_64-pc-cygwin -DNDEBUG' res.rc res.o
wintext.c: In function âwin_textâ:
wintext.c:522:13: error: array subscript is above array bounds
   if (!fonts[nfont]) {
cc1: all warnings being treated as errors
Makefile:117: recipe for target 'wintext.o' failed
make: *** [wintext.o] Error 1

This can at least be made into a warning by taking off -Werror, but it looks
like it might be a real off-by-one. Our neighbors over at MSYS2 have a patch
(the packaging repo there has a BSD 3-clause license) to change FONT_MAXNO
in wintext.c from 0x1F to 0x20.
Sadly the mintty maintainer is AWOL for quite some time.  Would you
like to take over maintainership?  Given the overall stability of the
package, maintaining it shouldn't be much of a burden.
I have contributed to mintty before and will look into this issue.
I'd like to discuss further details in PM if you like.

Problem reports:
Unsubscribe info:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]