This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: 'more' segment faults with latest cygwin1.dll (1.7.11)

On Tue, 2012-02-28 at 11:24 +0100, Corinna Vinschen wrote:
> On Feb 28 03:43, Yaakov (Cygwin/X) wrote:
> > On Tue, 2012-02-28 at 09:18 +0100, Corinna Vinschen wrote:
> > > It's a bug in more, afaics.  In case of pressing 'n', the search function
> > > is called with a NULL buf argument.  However, the function calls
> > > strlen(buf) without checking buf for NULL.  The indentation at this
> > > point in the file looks like this  `if (strlen(buf) > 0) {' has been
> > > added as a kind of patch.
> > 
> > Yes, I had to patch more(1) to use regcomp/regexec instead of
> > re_comp/re_exec, which we don't have on Cygwin.  With your clarification
> > I should be able to fix it easily.
> Just an idea, instead of working around them, why not just add them
> to the lib?  You could copy the FreeBSD implementation which just
> implements them in terms of the regcomp/regexec API:

I thought of that when I first ported util-linux, but these functions
were already marked legacy in SUSv2 and removed from SUSv3, so I wasn't
sure if we wanted to first add now what most libc's already consider

If you really think this should be added to Cygwin, I could do it, but I
already have a fix for more(1) so I could do without.


Problem reports:
Unsubscribe info:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]