This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: bug in pipe() and pipe2()

On Jun 30 07:50, Ryan Johnson wrote:
> On 30/06/2011 5:38 AM, Corinna Vinschen wrote:
> > I only see a very ugly workaround for this
> >problem.
> >
> >I checked it in, together with two more fixes to avoid a crash.
> >If somebody has a better solution, feel free to mention it.
> If you don't mind using a couple of gcc extensions (we are a
> gcc-only shop, right?):


> #define cnew(name, ...) ({                                              \
>             void* ptr = (void*) ccalloc (HEAP_FHANDLER, 1, sizeof
> (name)); \
>             ptr? new(ptr) name(__VA_ARGS__) : NULL;                     \
>         })
> The macro's usage would change to look like a normal function call:
> fhandler_base *fh = cnew(fhandler_nodevice);
> You just need to check fh != NULL afterward. If the ctor for
> fhandler_nodevice took an argument 'x' it would follow as additional
> args to the cnew macro, rather than as an additional set of parens:
> fhandler_base *fh = cnew(fhandler_nodevice, x);

Cool.  Thanks a lot.  I tried some ({ ... }) expression as well but
apparently gave up too early.  I applied your change since it's much
cleaner than my ugly hack.

Thanks again,

Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Problem reports:
Unsubscribe info:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]