Re: Regression in .exe extension handling

[Eric Blake <eblake at redhat dot com>]

On 06/29/2010 02:43 AM, Corinna Vinschen wrote:
>> It's definitely a bug (or two) somewhere:
>>
>> * "install foo" correctly installs 'foo' but the presence of foo.exe
>> apparently fools something to add the .exe.
>>
>> * the .exe is being added when the file is clearly not a PE executable,
>> nor a link thereto.
>>
>> Whether these bugs are coming from coreutils or cygwin, or both, I do
>> not know.
> 
> It doesn't look like a problem in Cygwin.  Strace shows there's an
> open("bar/foo.exe") call to create the file.
> 
> I assume it's the logic in install along the lines of
> 
>   stat("foo") shows that "foo" exists?
>   yes -> stat("foo.exe") shows that "foo.exe" exists?
>          yes -> so the original file is called "foo.exe".
> 
> Maybe the test should check for the entire struct stat to be identical
> before making this decision?  Just an idea...

Most likely, the hole is in coreutils' exe magic.  Looks like I'll be
working on a coreutils-8.5-3 today...

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature