This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New platform independent problem

[Resent to add emacs-devel and Eli on the "To:" list]

On Jan 20 06:59, Eric Blake wrote:
> According to Corinna Vinschen on 1/20/2006 5:25 AM:
> > I'm also having a problem right now building rcp and scp due to the
> > missing d_ino.  OTOH, the d_ino member is not required by POSIX, but
> > only in X/Open compliant OSes, see
> > 
> >
> >
> > 
> > So, portable applications shouldn't rely on d_ino.
> Is there a compromise here?  Many applications that look at d_ino also
> check whether the d_ino member is 0, in which case they fall back on
> st_ino.  For example, coreutils's pwd.c contains:
> #ifdef D_INO_IN_DIRENT
> # define D_INO(dp)((dp)->d_ino)
> #else
> /* Some systems don't have inodes, so fake them to avoid lots of ifdefs.  */
> # define D_INO(dp) NOT_AN_INODE_NUMBER
> #endif
> Then later on, it can blindly do:
> ino_t ino = D_INO(dp);
> if (ino == NOT_AN_INODE_NUMBER)
>   {
>     if (lstat (dp->d_name, &ent_sb) < 0)
>       continue; /* Skip any entry we can't stat.  */
>     ino = ent_sb.st_ino;
>   }

Well, other applications like rcp and scp just use d_ino to check for 0
and to ignore it entirely then, like this:

  while (readdir)
      if (d_ino == 0)

This means, if d_ino is 0, it breaks scp and rcp and some other
applications.  If it's always some arbitrary non-zero value, it breaks
pwd from coreutils and some other applications.  If it's available and
doesn't match st_ino, it breaks another set of applications.  If it's
not available at all, it breaks all applications asking for d_ino in any

> Cygwin would then set it to 0 on WinNT and 2k (where it is
> prohibitively expensive to determine a real value), set it to the hash on
> Win9x and ME (since st_ino is also the hash on those platforms), and set
> it to the actual st_ino value on WinXP and beyond (since the API exists).

That would be a better solution, though it would still not be ok to set
it to 0 on NT4 and 2K.  Maybe we should think about another way to
generate a hash value and use it on all platforms.  I'm just at a loss
right now, to come up with another hash generation method, which would
allow to get the same inode number for hardlinks :-(


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

Unsubscribe info:
Problem reports:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]