This is the mail archive of the cygwin mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] cygrunsrv --recovery <action>

On Thu, 30 Sep 2004, Corinna Vinschen wrote:

> On Sep 29 18:31, Rainer Hochreiter wrote:
> > the attached patch implements the options -r or --recovery to set service
> > failure actions. allowed actions are 'none', 'boot' or 'restar'.
> > not implemented are actions for running commands on failed actions, like
> > supported by the windows SCM.
> >
> > the patch also uses ChangeServiceConfig2() for setting the description of
> > the installed service.
> Thanks for the patch, but I can't apply it as it is, mainly  for two
> reasons.
> > not included is the ChangeLog of the patch!
> - This is reason one.
> - Please don't use ChangeServiceConfig2.  It will break running cygrunsrv
>   on NT4.  That's the reason the description is written directly to the
>   registry instead of using ChangeServiceConfig2.
> Also, what's the reason you didn't implement running commands?  I'm asking
> because there are still these `#if 0' parts left in your patch which point
> to the fact that you began to implement it but just stopped at one point.
> Corinna

And when you resubmit, please use "diff -u" instead of "diff -c" -- the
patch is much more readable that way.

One immediate change I noticed was that the description parameter migrated
from calls to install_registry_keys to calls to install_service, but you
haven't provided any changes to either of those functions.  Any reason for
      |\      _,,,---,,_
ZZZzz /,`.-'`'    -.  ;-;;,_
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Happiness lies in being privileged to work hard for long hours in doing
whatever you think is worth doing."  -- Dr. Jubal Harshaw

Unsubscribe info:
Problem reports:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]