This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Diff for generic readme and generic-build script


New patch - basically I store the /usr/bin/basename of the Readme file
variable == > /tmp/%PKG%.README

Then I do an effective "mv -f /tmp/%PKG%.README
/usr/share/doc/Cygwin/%PKG%.README" operation. Hopefully that mitigates all
of your concerns.

-----Original Message-----
From: Igor Pechtchanski []
Sent: November 19, 2003 11:55
Subject: RE: Diff for generic readme and generic-build script


The bug with 'sed -i' was that if it's unable to write to (or, rather,
"creat") "/tmp/sedGARBAGE", it assumes that the file exists and tries
another name ("/tmp/sedMOREGARBAGE"), and so on (in a loop).  If /tmp is
not writeable at all, sed will loop indefinitely.  As long as your script
checks only once (and redirection is usually better at handling existing
files, since you never claimed your script is reentrant), you should be
ok.  You can simply replace "${ThePackageReadMeFile}.tmp" in your patch
with "/tmp/${ThePackageReadMeFile}.tmp" (or even "`mktemp -t
"${ThePackageReadMeFile}.XXXXXX"`", but you'd need to store that in a

On Tue, 18 Nov 2003, Alan Miles wrote:

> Igor,
> With this change I discovered a very subtle problem - the files listed
> show two entries instead of one for the README:
> /usr/share/doc/Cygwin/%PKG%.README
> /usr/share/doc/Cygwin/%PKG%.README.tmp
> This is due to the way where I redirected the file to.
> There are two solutions:
> 1/ Put the redirected temp file under /tmp, i.e., /tmp/%PKG%.README and
> doing a 'mv -f /tmp/%PKG%.README /usr/share/doc/Cygwin/%PKG%.README'. The
> listing won't be affected since before and after will contain the same
> name.
> 2/ Adjusting the find command to filter-out the
> /usr/share/doc/Cygwin/%PKG%.README.tmp file in its listing.
> Which solution would be your preference? (Unless you have another one of
> course ...)
> Alan

Attachment: packaging_templates.diff
Description: Binary data

Unsubscribe info:
Problem reports:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]